bpo-36035: pathlib.Path().rglob() breaks with broken symlinks#11964
Closed
eamanu wants to merge 2 commits intopython:masterfrom
Closed
bpo-36035: pathlib.Path().rglob() breaks with broken symlinks#11964eamanu wants to merge 2 commits intopython:masterfrom
eamanu wants to merge 2 commits intopython:masterfrom
Conversation
Based on Jörg Stucke suggestion
pganssle
requested changes
Apr 14, 2019
Member
pganssle
left a comment
There was a problem hiding this comment.
I think it would be best if you also added a test for this, presumably in test_pathlib.
BoboTiG
reviewed
Apr 14, 2019
| @@ -35,7 +35,7 @@ | |||
| # | |||
|
|
|||
| # EBADF - guard agains macOS `stat` throwing EBADF | |||
Contributor
There was a problem hiding this comment.
Perhpas adding a comment here about ELOOP ould be helpful as this name is not transparent.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bpo-36035: adding ELOOP variable to _IGNORED_ERROS
Based on Jörg Stucke suggestion
https://bugs.python.org/issue36035