bpo-36026: make descr error message consistent #11930
Conversation
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Could you please provide tests?
Objects/descrobject.c
Outdated
There was a problem hiding this comment.
Why has this been changed?
There was a difference with classmethod descriptors, but classmethod descriptors were special, they are applied to types, not instances.
There was a problem hiding this comment.
This message is for method, not classmethod. But I changed classmethod error message too.
I feel same error message makes sense for classmethod too.
Discuss about actual error message on bpo.
Objects/descrobject.c
Outdated
There was a problem hiding this comment.
Maybe, this is a really old bug (commit).
>>> desc = set.add
>>> desc(int)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: descriptor 'add' requires a 'set' object but received a 'type'
This should be ...but received a 'int', not 'type'.
There was a problem hiding this comment.
>>> desc(1)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: descriptor 'add' requires a 'set' object but received a 'int'
>>> desc(set)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: descriptor 'add' requires a 'set' object but received a 'type'
There was a problem hiding this comment.
This does not look like a bug to me. If you will change it to produce ...but received a 'int', you will get ... requires a 'set' object but received a 'set' for desc(set), and I have no idea what you will get for descr(1).
There was a problem hiding this comment.
I'm sorry, my example was wrong. This is classmethoddesc_call.
>>> desc2 = dict.__dict__['fromkeys']
>>> desc2(int, [])
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: descriptor 'fromkeys' requires a subtype of 'dict' but received 'type
'type must be 'int'.
There was a problem hiding this comment.
set.add(0) and set.add.__get__(0) now raise TypeError with same error message.
set.add(0)andset.add.__get__(0)now raise TypeError with same error message.https://bugs.python.org/issue36026