GH-117536: ensure asyncgens GCd before runner teardown get aclosed#117577
Closed
graingert wants to merge 1 commit intopython:mainfrom
Closed
GH-117536: ensure asyncgens GCd before runner teardown get aclosed#117577graingert wants to merge 1 commit intopython:mainfrom
graingert wants to merge 1 commit intopython:mainfrom
Conversation
Contributor
Author
|
some tests needed:
|
graingert
commented
Apr 6, 2024
|
|
||
| if not len(self._asyncgens): | ||
| closing_agens = list(self._asyncgens) | ||
| closing_agens.extend(self._closing_asyncgens.copy()) |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| closing_agens.extend(self._closing_asyncgens.copy()) | |
| closing_agens.extend(self._closing_asyncgens) |
Contributor
Author
|
My original diagnosis of the problem was wrong, async gens .aclose() get cancelled but still scheduled |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.