Skip to content

[3.7] bpo-35560: Remove assertion from format(float, "n") (GH-11288)#11458

Merged
miss-islington merged 1 commit into
python:3.7from
miss-islington:backport-3f7983a-3.7
Jan 7, 2019
Merged

[3.7] bpo-35560: Remove assertion from format(float, "n") (GH-11288)#11458
miss-islington merged 1 commit into
python:3.7from
miss-islington:backport-3f7983a-3.7

Conversation

@miss-islington

@miss-islington miss-islington commented Jan 7, 2019

Copy link
Copy Markdown
Contributor

Fix an assertion error in format() in debug build for floating point
formatting with "n" format, zero padding and small width. Release build is
not impacted. Patch by Karthikeyan Singaravelan.
(cherry picked from commit 3f7983a)

Co-authored-by: Xtreak tir.karthi@gmail.com

https://bugs.python.org/issue35560

Fix an assertion error in format() in debug build for floating point
formatting with "n" format, zero padding and small width. Release build is
not impacted. Patch by Karthikeyan Singaravelan.
(cherry picked from commit 3f7983a)

Co-authored-by: Xtreak <tir.karthi@gmail.com>

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington

Copy link
Copy Markdown
Contributor Author

@tirkarthi and @vstinner: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 9a413fa into python:3.7 Jan 7, 2019
@miss-islington miss-islington deleted the backport-3f7983a-3.7 branch January 7, 2019 15:26
@miss-islington

Copy link
Copy Markdown
Contributor Author

@tirkarthi and @vstinner: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants