Skip to content

bpo-35306: Handle '*' in pathlib.Path functions on Windows #11133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vladima wants to merge 2 commits into from
Closed

bpo-35306: Handle '*' in pathlib.Path functions on Windows #11133

vladima wants to merge 2 commits into from

Conversation

@vladima
Copy link
Contributor

@vladima vladima commented Dec 12, 2018 •
edited by bedevere-bot
Loading

Added EINVAL to the set of ignored errors as suggested in comment.

https://bugs.python.org/issue35306

@vladima
Copy link
Contributor Author

vladima commented Dec 14, 2018

@eryksun this is what was proposed in a discussion, can you please take a look?

@vladima
Copy link
Contributor Author

vladima commented Dec 25, 2018

@eryksun can you please tell if there is anything else that needs to be done here?

@vladima
Copy link
Contributor Author

vladima commented Jan 4, 2019

is there anything else that should be done for this PR?

zware
zware approved these changes Sep 11, 2019
View reviewed changes
Copy link
Member

@zware zware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me after a rebase, though @pitrou may want to have a look.

@zware zware requested a review from pitrou September 11, 2019 17:09
pitrou
pitrou approved these changes Apr 17, 2020
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. @vladima Would you like to rebase / merge from master a last time and fix conflicts?

@zooba
Copy link
Member

zooba commented Apr 22, 2021 •
edited
Loading

Apologies for not seeing this before I did my own patch :( It's fixed now

Thanks for submitting the PR anyway!

@zooba zooba closed this Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou approved these changes

@zware zware zware approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vladima @zooba @pitrou @zware @the-knights-who-say-ni @bedevere-bot