Skip to content

gh-107583: Update Doc/howto/unicode.rst#109501

Open
xzmeng wants to merge 1 commit into
python:mainfrom
xzmeng:howto-unicode-107583
Open

gh-107583: Update Doc/howto/unicode.rst#109501
xzmeng wants to merge 1 commit into
python:mainfrom
xzmeng:howto-unicode-107583

Conversation

@xzmeng

@xzmeng xzmeng commented Sep 16, 2023

Copy link
Copy Markdown
Contributor
  • Replace PEP 263 with Encoding declarations to avoid misleading
  • Reorder paragraphs about encoding comment to put Emacs thing behind
  • Mark the link about Python 2 as "For historical interest"

📚 Documentation preview 📚: https://cpython-previews--109501.org.readthedocs.build/

Comment thread Doc/howto/unicode.rst
EuroPython 2002. The slides are an excellent overview of the design of Python
2's Unicode features (where the Unicode string type is called ``unicode`` and
literals start with ``u``).
literals start with ``u``). (Notice: Python 2 is no longer supported, just keep it

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better: (Note: Python 2 is no longer supported. We just keep this reference for historic reasons.)

Comment thread Doc/howto/unicode.rst

If you don't include such a comment, the default encoding used will be UTF-8 as
already mentioned. See also :pep:`263` for more information.
already mentioned.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the reference to PEP 263, since this explains how it all works.

@bedevere-app

bedevere-app Bot commented Jan 18, 2024

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Comment thread Doc/howto/unicode.rst
they have no significance to Python but are a convention. Python looks for
``coding: name`` or ``coding=name`` in the comment.
Python looks for patterns such like ``coding: latin-1``, ``coding=latin-1`` or
``-*- coding: latin-1 -*-`` in the comment. See :ref:`encodings` for detailed

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
``-*- coding: latin-1 -*-`` in the comment. See :ref:`encodings` for detailed
``-*- coding: latin-1 -*-`` in the comment. See :ref:`encodings` for a detailed

Grammar nit

Comment thread Doc/howto/unicode.rst
Comment on lines +536 to +537
literals start with ``u``). (Notice: Python 2 is no longer supported, just keep it
here for historical interest.)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
literals start with ``u``). (Notice: Python 2 is no longer supported, just keep it
here for historical interest.)
literals start with ``u``). (Note: Python 2 is no longer supported.
This reference is preserved for historic reasons.)

A slightly different suggestion to the above.

@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting changes docs Documentation in the Doc dir skip news stale Stale PR or inactive for long period of time.

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

5 participants