bpo-35368: Add assertions in pymalloc to check GIL #10866
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add "assert(PyGILState_Check());" assertion to pymalloc functions like pymalloc_alloc() to ensure that the GIL is held. Remove also _PyGILState_check_enabled define: use directly _PyRuntime.gilstate.check_enabled. Note: The debug hook already uses _PyMem_DebugCheckGIL() to check that the GIL is held.
Member
Author
|
This change is not really a bugfix. If Python is compiled in debug mode, debug hooks are installed by default and so _PyMem_DebugCheckGIL() is checked by each PyMem_Malloc() and PyObject_Malloc() call. This change only impacts PYTHONMALLOC=pymalloc case on Python compiled in debug mode. The assertion is more here as a "documentation" that pymalloc is not thread-safe (currently). |
Member
Author
This PR adds an overhead at runtime for little benefit, so I abandon my PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "assert(PyGILState_Check());" assertion to pymalloc functions
like pymalloc_alloc() to ensure that the GIL is held.
Remove also _PyGILState_check_enabled define: use directly
_PyRuntime.gilstate.check_enabled.
Note: The debug hook already uses _PyMem_DebugCheckGIL() to check
that the GIL is held.
https://bugs.python.org/issue35368