-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
bpo-34784: Prevent creating types without bases on PyTuple_Pack failure #10536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Oh dear. There are a few more things I overlooked that should be freed on errors. |
|
@encukou Yup! Thanks for pushing the commit :) |
|
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
|
Sorry, @pablogsal, I could not cleanly backport this to |
|
Sorry, @pablogsal, I could not cleanly backport this to |
|
Wait....the original PR was not backported. There is nothing to backport here. |
|
|
Seems like a false alarm, retriggering build: |
PyTuple_Packcan fail and returnNULL. If this happens, thenPyType_FromSpecWithBaseswill incorrectly create a new type without bases. Also, it will crash on thePy_DECREFthat follows.https://bugs.python.org/issue34784