Skip to content

gh-102336: Ensure CancelIoEx result is not ignored#102347

Merged
zooba merged 1 commit intopython:mainfrom
maxbachmann:patch-10
Mar 1, 2023
Merged

gh-102336: Ensure CancelIoEx result is not ignored#102347
zooba merged 1 commit intopython:mainfrom
maxbachmann:patch-10

Conversation

@maxbachmann
Copy link
Copy Markdown
Contributor

@maxbachmann maxbachmann commented Mar 1, 2023

@zooba This fixes a bug I introduced in #102337, where I ignore the return value of CancelIoEx

@zooba zooba changed the title fix ignored return value gh-102336: Ensure CancelIoEx result is not ignored Mar 1, 2023
@zooba zooba added the skip news label Mar 1, 2023
@zooba zooba merged commit d3d2074 into python:main Mar 1, 2023
@zooba
Copy link
Copy Markdown
Member

zooba commented Mar 1, 2023

Thanks. I'm sure you can see the process followed here, but it's fine to reuse the same bug number for a follow-up fix, and we can skip the NEWS requirement. We generally try to keep the commit messages specific though, for people who are reading them without following through the bug links (at least specific enough to hint at the platform, so that it's easy to skim over them in a git log output).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants