Support the "pager" binary in _pyrepl#122878
Merged
vstinner merged 4 commits intopython:mainfrom Sep 19, 2024
Merged
Conversation
Debian (and derivatives) provide a /usr/bin/pager binary, managed by the alternatives system, that always points to an available pager utility. Allow _pyrepl to use it, to follow system policy This is a very trivial change, from a patch that Debian has been carrying since 2.7 era. Seems appropriate to upstream. https://bugs.debian.org/799555
vstinner
approved these changes
Sep 18, 2024
Member
vstinner
left a comment
There was a problem hiding this comment.
LGTM. IMO it's reasonable to try pager before less. On Fedora, there is no pager command, it will silently be ignored as expected which is fine.
Member
|
It's user-visible change, I think it worth a changelog entry. |
Member
|
@stefanor: See https://devguide.python.org/ for how to add a Changelog (NEWS) entry. |
Contributor
Author
|
Added a NEWS entry. |
b622900 to
eaf8ae0
Compare
vstinner
reviewed
Sep 19, 2024
Misc/NEWS.d/next/Core_and_Builtins/2024-09-19-13-17-31.gh-issue-122878.4iFpsB.rst
Outdated
Show resolved
Hide resolved
…e-122878.4iFpsB.rst
skirpichev
reviewed
Sep 19, 2024
Misc/NEWS.d/next/Core_and_Builtins/2024-09-19-13-17-31.gh-issue-122878.4iFpsB.rst
Outdated
Show resolved
Hide resolved
…e-122878.4iFpsB.rst Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
skirpichev
approved these changes
Sep 19, 2024
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 19, 2024
Debian (and derivatives) provide a /usr/bin/pager binary, managed by the alternatives system, that always points to an available pager utility. Allow _pyrepl to use it, to follow system policy. This is a very trivial change, from a patch that Debian has been carrying since 2.7 era. Seems appropriate to upstream. https://bugs.debian.org/799555 (cherry picked from commit 426569e) Co-authored-by: Stefano Rivera <stefano@rivera.za.net>
|
GH-124242 is a backport of this pull request to the 3.13 branch. |
Member
|
Merged, thanks @stefanor. |
savannahostrowski
pushed a commit
to savannahostrowski/cpython
that referenced
this pull request
Sep 22, 2024
Debian (and derivatives) provide a /usr/bin/pager binary, managed by the alternatives system, that always points to an available pager utility. Allow _pyrepl to use it, to follow system policy. This is a very trivial change, from a patch that Debian has been carrying since 2.7 era. Seems appropriate to upstream. https://bugs.debian.org/799555
vstinner
pushed a commit
that referenced
this pull request
Oct 7, 2024
Support the "pager" binary in _pyrepl (GH-122878) Debian (and derivatives) provide a /usr/bin/pager binary, managed by the alternatives system, that always points to an available pager utility. Allow _pyrepl to use it, to follow system policy. This is a very trivial change, from a patch that Debian has been carrying since 2.7 era. Seems appropriate to upstream. https://bugs.debian.org/799555 (cherry picked from commit 426569e) Co-authored-by: Stefano Rivera <stefano@rivera.za.net> Co-authored-by: T. Wouters <thomas@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Debian (and derivatives) provide a /usr/bin/pager binary, managed by the alternatives system, that always points to an available pager utility. Allow _pyrepl to use it, to follow system policy
This is a very trivial change, from a patch that Debian has been carrying since 2.7 era. Seems appropriate to upstream. https://bugs.debian.org/799555