bpo-33056 FIX leaking fd in concurrent.futures.ProcessPoolExecutor (GH-6084) (#6092)

miss-islington · tomMoral · pitrou · commit f216cbf9ab70 · 2018-03-13T10:10:57.000+01:00
(cherry picked from commit 095ee41) Co-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com>
diff --git a/Lib/concurrent/futures/process.py b/Lib/concurrent/futures/process.py
@@ -78,11 +78,13 @@
 
 
 class _ThreadWakeup:
-    __slot__ = ["_state"]
-
     def __init__(self):
         self._reader, self._writer = mp.Pipe(duplex=False)
 
+    def close(self):
+        self._writer.close()
+        self._reader.close()
+
     def wakeup(self):
         self._writer.send_bytes(b"")
 
@@ -654,6 +656,11 @@ def shutdown(self, wait=True):
             self._call_queue = None
         self._result_queue = None
         self._processes = None
+
+        if self._queue_management_thread_wakeup:
+            self._queue_management_thread_wakeup.close()
+            self._queue_management_thread_wakeup = None
+
     shutdown.__doc__ = _base.Executor.shutdown.__doc__
 
 atexit.register(_python_exit)
diff --git a/Misc/NEWS.d/next/Library/2018-03-12-16-40-00.bpo-33056.lNN9Eh.rst b/Misc/NEWS.d/next/Library/2018-03-12-16-40-00.bpo-33056.lNN9Eh.rst
@@ -0,0 +1 @@
+FIX properly close leaking fds in concurrent.futures.ProcessPoolExecutor.

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+FIX properly close leaking fds in concurrent.futures.ProcessPoolExecutor.`