Add testQuoteAlways to shlex tests

jb2170 · jb2170 · commit b8ef5ce375a1 · 2024-06-03T23:50:43.000+01:00
The first assertTrue test checks all strings now start with a single quote, ie they have actually been escaped

The second test of assertFalse checks that not all the strings have been escaped when always=False (the default value), since the first, third, and fifth string do not need escaping unless requested.
diff --git a/Lib/test/test_shlex.py b/Lib/test/test_shlex.py
@@ -337,6 +337,18 @@ def testQuote(self):
             self.assertEqual(shlex.quote("test%s'name'" % u),
                              "'test%s'\"'\"'name'\"'\"''" % u)
 
+    def testQuoteAlways(self):
+        strs = ['hello', 'to the', 'world', 'escape me', 'no-escape-needed']
+
+        # guarantee escaping all strings
+        strs_always_escaped = [shlex.quote(s, always=True) for s in strs]
+        self.assertTrue(all(s.startswith("'") for s in strs_always_escaped))
+
+        # just escape when necessary ('to the', 'escape me')
+        strs_necessary_escaped = [shlex.quote(s, always=False) for s in strs]
+        self.assertFalse(all(s.startswith("'")
+                             for s in strs_necessary_escaped))
+
     def testJoin(self):
         for split_command, command in [
             (['a ', 'b'], "'a ' b"),
