bpo-29876: fix DECREF for NULL value in subelement() (GH-760)

zhangyangyu · web-flow · commit 9c0408d9b68d · 2017-03-22T14:32:52.000+08:00
diff --git a/Modules/_elementtree.c b/Modules/_elementtree.c
@@ -524,8 +524,9 @@ subelement(PyObject* self, PyObject* args, PyObject* kw)
     }
 
     elem = element_new(tag, attrib);
-
     Py_DECREF(attrib);
+    if (elem == NULL)
+        return NULL;
 
     if (element_add_subelement(parent, elem) < 0) {
         Py_DECREF(elem);

Original file line number	Diff line number	Diff line change
`@@ -524,8 +524,9 @@ subelement(PyObject* self, PyObject* args, PyObject* kw)`
`524`	`524`	`}`
`525`	`525`
`526`	`526`	`elem = element_new(tag, attrib);`
`527`		`-`
`528`	`527`	`Py_DECREF(attrib);`
	`528`	`+ if (elem == NULL)`
	`529`	`+ return NULL;`
`529`	`530`
`530`	`531`	`if (element_add_subelement(parent, elem) < 0) {`
`531`	`532`	`Py_DECREF(elem);`