bpo-32252: Fix faulthandler_suppress_crash_report() (GH-4794) (#4795)

miss-islington · vstinner · commit 71d8f36eb450 · 2017-12-11T14:17:06.000+01:00
Fix faulthandler_suppress_crash_report() used to prevent core dump files when testing crashes. getrlimit() returns zero on success. (cherry picked from commit 48d4dd9)
diff --git a/Misc/NEWS.d/next/Tests/2017-12-11-13-31-33.bpo-32252.YnFw7J.rst b/Misc/NEWS.d/next/Tests/2017-12-11-13-31-33.bpo-32252.YnFw7J.rst
@@ -0,0 +1,2 @@
+Fix faulthandler_suppress_crash_report() used to prevent core dump files
+when testing crashes. getrlimit() returns zero on success.
diff --git a/Modules/faulthandler.c b/Modules/faulthandler.c
@@ -936,7 +936,7 @@ faulthandler_suppress_crash_report(void)
     struct rlimit rl;
 
     /* Disable creation of core dump */
-    if (getrlimit(RLIMIT_CORE, &rl) != 0) {
+    if (getrlimit(RLIMIT_CORE, &rl) == 0) {
         rl.rlim_cur = 0;
         setrlimit(RLIMIT_CORE, &rl);
     }

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+Fix faulthandler_suppress_crash_report() used to prevent core dump files`
	`2`	`+when testing crashes. getrlimit() returns zero on success.`
Original file line number	Diff line number	Diff line change
`@@ -936,7 +936,7 @@ faulthandler_suppress_crash_report(void)`
`936`	`936`	`struct rlimit rl;`
`937`	`937`
`938`	`938`	`/* Disable creation of core dump */`
`939`		`- if (getrlimit(RLIMIT_CORE, &rl) != 0) {`
	`939`	`+ if (getrlimit(RLIMIT_CORE, &rl) == 0) {`
`940`	`940`	`rl.rlim_cur = 0;`
`941`	`941`	`setrlimit(RLIMIT_CORE, &rl);`
`942`	`942`	`}`