bpo-30961: Fix decrementing a borrowed reference in tracemalloc. (#2747)

zhangyangyu · web-flow · commit 4ed5ad79ec6c · 2017-07-19T00:33:29.000+08:00
diff --git a/Misc/NEWS.d/next/Library/2017-07-18-23-47-51.bpo-30961.064jz0.rst b/Misc/NEWS.d/next/Library/2017-07-18-23-47-51.bpo-30961.064jz0.rst
@@ -0,0 +1 @@
+Fix decrementing a borrowed reference in tracemalloc.
diff --git a/Modules/_tracemalloc.c b/Modules/_tracemalloc.c
@@ -1752,7 +1752,7 @@ _PyTraceMalloc_Init(void)
         if (key == NULL)
             return -1;
 
-        value = PyDict_GetItemWithError(xoptions, key);
+        value = PyDict_GetItemWithError(xoptions, key); /* borrowed */
         Py_DECREF(key);
         if (value == NULL) {
             if (PyErr_Occurred())
@@ -1763,7 +1763,6 @@ _PyTraceMalloc_Init(void)
         }
 
         nframe = parse_sys_xoptions(value);
-        Py_DECREF(value);
         if (nframe < 0) {
             Py_FatalError("-X tracemalloc=NFRAME: invalid number of frames");
         }

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Fix decrementing a borrowed reference in tracemalloc.`
Original file line number	Diff line number	Diff line change
`@@ -1752,7 +1752,7 @@ _PyTraceMalloc_Init(void)`
`1752`	`1752`	`if (key == NULL)`
`1753`	`1753`	`return -1;`
`1754`	`1754`
`1755`		`- value = PyDict_GetItemWithError(xoptions, key);`
	`1755`	`+ value = PyDict_GetItemWithError(xoptions, key); /* borrowed */`
`1756`	`1756`	`Py_DECREF(key);`
`1757`	`1757`	`if (value == NULL) {`
`1758`	`1758`	`if (PyErr_Occurred())`
`@@ -1763,7 +1763,6 @@ _PyTraceMalloc_Init(void)`
`1763`	`1763`	`}`
`1764`	`1764`
`1765`	`1765`	`nframe = parse_sys_xoptions(value);`
`1766`		`- Py_DECREF(value);`
`1767`	`1766`	`if (nframe < 0) {`
`1768`	`1767`	`Py_FatalError("-X tracemalloc=NFRAME: invalid number of frames");`
`1769`	`1768`	`}`