Skip to content

Commit 324e179

Browse files
[2.7] bpo-33023: Fix NotImplemented to NotImplementedError. (GH-10934). (GH-11001) (GH-11008)
(cherry picked from commit 42b1d61) (cherry picked from commit 7a2cf1e)
1 parent 107b27e commit 324e179

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

Lib/ssl.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -630,8 +630,8 @@ def context(self, ctx):
630630
self._sslobj.context = ctx
631631

632632
def dup(self):
633-
raise NotImplemented("Can't dup() %s instances" %
634-
self.__class__.__name__)
633+
raise NotImplementedError("Can't dup() %s instances" %
634+
self.__class__.__name__)
635635

636636
def _checkClosed(self, msg=None):
637637
# raise an exception here if you wish to check for spurious closes

Lib/test/test_ssl.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -341,6 +341,7 @@ def test_wrapped_unconnected(self):
341341
self.assertRaises(socket.error, ss.recvfrom_into, bytearray(b'x'), 1)
342342
self.assertRaises(socket.error, ss.send, b'x')
343343
self.assertRaises(socket.error, ss.sendto, b'x', ('0.0.0.0', 0))
344+
self.assertRaises(NotImplementedError, ss.dup)
344345

345346
def test_timeout(self):
346347
# Issue #8524: when creating an SSL socket, the timeout of the
@@ -2645,6 +2646,7 @@ def _recvfrom_into():
26452646
self.assertEqual(s.read(-1, buffer), len(data))
26462647
self.assertEqual(buffer, data)
26472648

2649+
self.assertRaises(NotImplementedError, s.dup)
26482650
s.write(b"over\n")
26492651

26502652
self.assertRaises(ValueError, s.recv, -1)

0 commit comments

Comments
 (0)