This repository was archived by the owner on Nov 23, 2017. It is now read-only.
Fix create_unix_server to support Path-like objects (PEP 519)#462
Closed
1st1 wants to merge 1 commit into
Closed
Conversation
asvetlov
reviewed
Nov 12, 2016
| _fspath = os.fspath | ||
| except AttributeError: | ||
| # Python 3.5 or earlier | ||
| _fspath = lambda path: path |
There was a problem hiding this comment.
Maybe support pathlib.Path for Python 3.5 also?
It could be implemented by isinstance() check.
Member
Author
There was a problem hiding this comment.
I don't think it's a good idea, PEP 519 is 3.6 only.
Member
There was a problem hiding this comment.
I think the key point is that unless a library implementing a path-representing object restricts itself to 3.6 or newer, it could be useful in 3.5 code. But I wouldn't use isinstance() as that's too restrictive if you want to bother supporting __fspath__. All you really need to be good enough for a os.fspath() fall-back is:
def _fspath(path):
if hasattr(path, '__fspath__'):
return path.__class__.__fspath__(path)
else:
return pathos.fspath() does more checks to verify that only str and bytes are returned, but that's the gist of it. Otherwise just do what Yury did.
Member
Author
|
Pushed in fff05d4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the recent commits broke support of PEP 519. This PR fixes
loop.create_unix_serverto support Path-like objects + a regression test.cc @brettcannon