fix(hip-3-pusher): SEDA client optimization, pusher error fix, dev dependency fix#3486
fix(hip-3-pusher): SEDA client optimization, pusher error fix, dev dependency fix#3486
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
tejasbadadare
left a comment
There was a problem hiding this comment.
Did your findings point you to uv being a problem? Afaik, uv run just solves the environment (packages, etc) before handing control to the python interpreter. So it's not that different to running python directly.
| self._handle_response(push_response, list(oracle_pxs.keys())) | ||
| except PushError: | ||
| # since rate limiting is expected, don't necessarily log | ||
| logger.error("Push API call failed") |
There was a problem hiding this comment.
logger.exception to include the exc context. Are there any useful details in the PushError?
There was a problem hiding this comment.
There are not in this path, hence error. Exception is caught and logged prior.
There was a problem hiding this comment.
Eh, changing it to exception anyway, no harm.
| from mypy_boto3_kms import KMSClient | ||
| if TYPE_CHECKING: | ||
| from mypy_boto3_kms import KMSClient | ||
| else: | ||
| KMSClient = Any |
There was a problem hiding this comment.
Can you explain what this does pls
There was a problem hiding this comment.
This is only used to type annotate. Without this running bare python chokes on this only being a dev dependency.
Summary
Rationale
Remediate oomkills in production.
How has this been tested?