Contract Manager: Explicitly select Sui environment, add custom Wormhole deploy script#3474
Contract Manager: Explicitly select Sui environment, add custom Wormhole deploy script#3474matej-douro merged 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
4 Skipped Deployments
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e844364bb0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| jq -r '.base64WithFlag' | ||
| ) | ||
|
|
||
| set -xeuo pipefail |
There was a problem hiding this comment.
Enable strict mode before deriving signing keys
set -xeuo pipefail is activated only after the sui keytool ... | jq ... assignments, so failures in sui keytool export/convert (for example an invalid --key-alias or CLI error) are masked because pipefail is not active and jq exits successfully on empty input. In that case SUI_KEY/WORM_KEY can become empty and the script proceeds into publish/init steps with invalid credentials instead of failing fast, which makes deployments fail later and less predictably.
Useful? React with 👍 / 👎.
Summary
Smaller changes in preparation for mainnet deployment.
Rationale
How has this been tested?