feat(hip-3-pusher): Support SEDA pass-through field types#3460
Merged
feat(hip-3-pusher): Support SEDA pass-through field types#3460
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Comment on lines
+203
to
+204
| elif isinstance(timestamp_field, int): | ||
| timestamp = timestamp_field / 1000.0 |
Contributor
There was a problem hiding this comment.
Can you document what's going on here? (are we coercing micros to millis, millis to seconds, etc)
And can we depend on the timestamp field to always have this precision?
Contributor
Author
There was a problem hiding this comment.
Good catch. This is a hack to handle a particular SEDA feed they need to fix.
tejasbadadare
approved these changes
Feb 23, 2026
…ike/hip-3-seda-new-format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rationale
How has this been tested?