Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 703062bf0e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Reset page when status filter changes | ||
| useEffect(() => { | ||
| updatePage(1); | ||
| }, [selectedStates, updatePage]); |
There was a problem hiding this comment.
Preserve deep-linked page instead of resetting on mount
This effect always calls updatePage(1) on the initial render, because selectedStates is initialized in state and the effect runs once on mount. That means a deep link such as ?page=3 (or any non-default page restored by useQueryParamFilterPagination) will be immediately overwritten back to page 1 even before the user changes the status filter. This regression only appears when the page is opened with a non-default page in the query params; consider guarding the reset so it only runs after an explicit filter change.
Useful? React with 👍 / 👎.
apps/developer-hub/src/components/PriceFeedIdsProTable/index.module.scss
Outdated
Show resolved
Hide resolved
apps/developer-hub/src/components/PriceFeedIdsProTable/index.module.scss
Outdated
Show resolved
Hide resolved
apps/developer-hub/src/components/PriceFeedIdsProTable/index.module.scss
Outdated
Show resolved
Hide resolved
apps/developer-hub/src/components/PriceFeedIdsProTable/index.tsx
Outdated
Show resolved
Hide resolved
|
You ave to select InActive and de select all other for the intended beaviour |
Summary
Rationale
How has this been tested?