Modernise codebase for Python 3.5+#557
Closed
hugovk wants to merge 10 commits intopytest-dev:emancipationfrom
Closed
Modernise codebase for Python 3.5+#557hugovk wants to merge 10 commits intopytest-dev:emancipationfrom
hugovk wants to merge 10 commits intopytest-dev:emancipationfrom
Conversation
nicoddemus
approved these changes
Jul 13, 2020
Member
|
Implementation note: I propose to wait for the release of Pytest 6, have a final review of #541 without these additional changes, then merge this PR into 541 and finally merge 541 into master. |
See issue pytest-dev#234. It's time.
8 tasks
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #541 drops support for EOL Python 2.7.
This PR updates #541 (not
master) to modernise the codebase:py35as the target (ie. minimum) version for Blackpyupgrade --py3-plussys.version_info[0] < 3:Here's a quick checklist that should be present in PRs:
Make sure to include reasonable tests for your change if necessary
[n/a?] We use towncrier for changelog management, so please add a news file into the
changelogfolder following these guidelines:Name it
$issue_id.$typefor example588.bugfix;If you don't have an issue_id change it to the PR id after creating it
Ensure type is one of
removal,feature,bugfix,vendor,docortrivialMake sure to use full sentences with correct case and punctuation, for example: