Skip to content

Make 'steal' command atomic#1144

Merged
nicoddemus merged 1 commit intopytest-dev:masterfrom
amezin:steal-atomic
Oct 30, 2024
Merged

Make 'steal' command atomic#1144
nicoddemus merged 1 commit intopytest-dev:masterfrom
amezin:steal-atomic

Conversation

@amezin
Copy link
Collaborator

@amezin amezin commented Oct 23, 2024

Either unschedule all requested tests, or none if it's not possible - if some of the requested tests have already been processed by the time the request arrives. It may happen if the worker runs tests faster than the controller receives and processes status updates. But in this case maybe it's just better to let the worker keep running.

This is a prerequisite for group/scope support in worksteal scheduler - so they won't be broken up incorrectly.

This change could break schedulers that use "steal" command. However:

  1. worksteal scheduler doesn't need any adjustments.

  2. I'm not aware of any external schedulers relying on this command yet.

So I think it's better to keep the protocol simple, not complicate it for imaginary compatibility with some unknown and likely non-existent schedulers.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants