Fix NotImplementedError crash when using xdist schedulers without mark_test_pending#309
Merged
icemac merged 6 commits intopytest-dev:masterfrom Oct 8, 2025
Merged
Fix NotImplementedError crash when using xdist schedulers without mark_test_pending#309icemac merged 6 commits intopytest-dev:masterfrom
NotImplementedError crash when using xdist schedulers without mark_test_pending#309icemac merged 6 commits intopytest-dev:masterfrom
Conversation
…k_test_pending Handle gracefully when pytest-xdist schedulers (like LoadScopeScheduling) don't implement mark_test_pending by catching NotImplementedError and failing the test with a clear message instead of crashing the test run. When a test crashes and cannot be rescheduled: - Set report outcome to "failed" with informative error message - Explain which scheduler lacks rescheduling support - Show remaining rerun count that couldn't be used - Continue test execution instead of internal crash Fixes pytest-dev#247
This was referenced Sep 25, 2025
Member
|
Can you separate infra changes (like the support matrix) from the actual functional changes in a separate PR? Also, the trove classifier update is missing from that. |
Contributor
Author
icemac
reviewed
Oct 8, 2025
icemac
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle gracefully when pytest-xdist schedulers (like
LoadScopeScheduling) don't implementmark_test_pendingby catchingNotImplementedErrorand failing the test with a clear message instead of crashing the test run.When a test crashes and cannot be rescheduled:
Fixes #247