Fix crash in runtest teardown hook#207
Merged
icemac merged 6 commits intopytest-dev:masterfrom Feb 17, 2023
Merged
Conversation
icemac
approved these changes
Feb 17, 2023
Contributor
icemac
left a comment
There was a problem hiding this comment.
LGTM, just some little changes.
Thank you for this PR.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refers to issue #206
I improved the implementation of the pytest runtest hook. Now the hook is compatible with test cases that use the TestCase class as base class. This fixes this error.
In addition I added a check to avoid this attribute error. It is clear that this does not fix the general problem with hooks beeing overwritten by other plugins.