Run teardown once after reruns#205
Conversation
|
Thank you for this PR. Could you please additionally write a test which shows that the bug is now fixed? |
|
Additionally tests seem to fail in |
|
I added a test to verify that the bug is fixed. The implementation should now be compatible with |
|
Thank you for fixing the code and adding a test. |
sallner
left a comment
There was a problem hiding this comment.
Looks good from my perspective.
|
Thank you for (reviewing) this PR. 😃 |
|
I just released https://pypi.org/project/pytest-rerunfailures/11.1/ containing this fix. |
|
These changes seem to cause #206. @lukasNebr Do you have an idea what could cause that error? |
|
I have no idea whats the cause of this error. I tried to reproduce the behavior but I was not successful. Basically the As you can see in the code the pytest-rerunfailures/pytest_rerunfailures.py Lines 562 to 573 in b20fef5 If you have also no idea what the cause of the error is I would implement a workaround to avoid the error. |
|
Regarding to #206 the problem is caused if another plugin also defines |
Fixes #51
Teardown of session, class, ... scoped fixture will be executed once after rerunning tests.
Used pytest version: 7.2.1