Skip to content

adopt to the pytest 5.4 internal changes#104

Merged
icemac merged 3 commits intopytest-dev:masterfrom
RonnyPfannschmidt:fix-103-support-new-fixturecache
Mar 17, 2020
Merged

adopt to the pytest 5.4 internal changes#104
icemac merged 3 commits intopytest-dev:masterfrom
RonnyPfannschmidt:fix-103-support-new-fixturecache

Conversation

@RonnyPfannschmidt
Copy link
Member

fixes #103

@RonnyPfannschmidt RonnyPfannschmidt changed the title adopt to the pytest 5.4 internal changes wip: adopt to the pytest 5.4 internal changes Mar 12, 2020
@RonnyPfannschmidt RonnyPfannschmidt force-pushed the fix-103-support-new-fixturecache branch from b842b7e to 586b374 Compare March 12, 2020 22:31
@RonnyPfannschmidt RonnyPfannschmidt changed the title wip: adopt to the pytest 5.4 internal changes adopt to the pytest 5.4 internal changes Mar 12, 2020
@icemac icemac requested review from The-Compiler and sallner March 13, 2020 07:25
@icemac
Copy link
Contributor

icemac commented Mar 13, 2020

I can't say much about the PR. At least a change log entry would be nice.

@bluetech
Copy link
Member

Whoops, in my searches I didn't catch that pytest-rerunfailures uses these private fields.

Next time, I'll clone all of the repos in pytest-dev organization and do a grep on that, in addition to github search.

Anyway, the PR looks good to me from a pytest perspective. In the future, it would be good to provide public & documented APIs for what pytest-rerunfailures needs, so it doesn't break silently again.

@dirk-thomas
Copy link

I can confirm that this patch addresses the problem.

@sallner A patch release with this fix would be greatly appreciated.

@icemac
Copy link
Contributor

icemac commented Mar 17, 2020

@sallner should be back next week. Meanwhile I would be able to merge and release, but I'd like to have someone who actually reviews this PR. Is there anyone out there to do so?

@icemac icemac merged commit 8caf8e5 into pytest-dev:master Mar 17, 2020
@icemac
Copy link
Contributor

icemac commented Mar 18, 2020

Thank you, I just released https://pypi.org/project/pytest-rerunfailures/9.0/ including this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeError in _remove_cached_results_from_failed_fixtures with pytest 5.4

4 participants