remove redundant unittest.mock imports#203
Merged
nicoddemus merged 1 commit intopytest-dev:masterfrom Aug 29, 2020
Merged
Conversation
graingert
commented
Aug 24, 2020
Comment on lines
-90
to
+87
| :rtype: mock.MagicMock | ||
| :rtype: unittest.mock.MagicMock |
Member
Author
There was a problem hiding this comment.
do we care about :rtype:s here? can we use sphinx-autodoc-typehints instead?
Member
There was a problem hiding this comment.
Hey @graingert!
IMHO we can drop all types from the docs and rely solely on the type annotations.
About sphinx, we don't really have sphinx docs at the moment, so I don't think it matters.
Want to tackle this in this PR?
Member
Author
There was a problem hiding this comment.
I think worth defering to another pr
Member
|
I don't think this applies anymore given we use Feel free to reopen if I'm wrong however! |
Member
Author
|
unittest.mock is imported 3 times, we only need it once |
Member
|
Ahh right, my bad! Sorry about that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.