Merged
Conversation
nicoddemus
approved these changes
Aug 24, 2020
Member
nicoddemus
left a comment
There was a problem hiding this comment.
Thanks a lot @srittau, indeed I missed those.
50d076c to
16d44f6
Compare
graingert
reviewed
Aug 24, 2020
Annotate MockerFixture.patch(). Without an explicit annotations, mypy and other type checkers can't determine the proper type and assume Any. MockerFixture.patch() can return an arbitrary type if either new or new_callable is provided. Add overloads to handle these cases.
f52d396 to
2fd1ac5
Compare
This was referenced Mar 12, 2021
1 task
1 task
1 task
1 task
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MockerFixture.patch(). Without an explicit annotations, mypy and other type checkers can't determine the proper type and assumeAny.MockerFixture.patch()can return an arbitrary type if eithernewornew_callableis provided. Add overloads to handle these cases.