Drop python 3.8, add support for 3.12, 3.13#842
Conversation
aec3c92 to
0fe67f2
Compare
|
Most errors are related to However, the code: except AttributeError:
# Needed for python < 3.9
return pkg_resources.resource_string(
"pytest_html", os.path.join("assets", "style.css")
).decode("utf-8")We shouldn't hit. So something is causing an attribute error here: https://github.com/pytest-dev/pytest-html/blob/master/testing/test_unit.py#L22 EDIT: Just realized we can just remove that code since we've dropped support for < 3.9. 🤷♂️ |
b97fe87 to
87f105b
Compare
87f105b to
02ca70c
Compare
|
Thanks for the review @BeyondEvil ! I did not manage to install locally yet (absolute path error I don't understand). Planning to work on this in the next few days and hopefully be able to reproduce the CI fail locally if adding setuptools doesn't work. |
Ugh... windows builds are always sooo slow. Anyway, I think it's fixed. Re-add the Thanks for the PR! ❤️ 🙏 |
|
Nice ! Will do. I plan to merge all the dependabot one next, there's a bunch of pending cve warning that stressed me out :D |
BeyondEvil
left a comment
There was a problem hiding this comment.
Big thanks for this PR! 🙏
|
Thank you for fixing the pipeline, I had a hard time setting up the dev env locally to troubleshoot ! |
No description provided.