Skip to content

Customize collapsed rows with a query param#168

Merged
davehunt merged 2 commits intopytest-dev:masterfrom
jacebrowning:custom-collapsed
Jun 1, 2018
Merged

Customize collapsed rows with a query param#168
davehunt merged 2 commits intopytest-dev:masterfrom
jacebrowning:custom-collapsed

Conversation

@jacebrowning
Copy link
Copy Markdown
Collaborator

Closes #157

The query param code is based on https://stackoverflow.com/a/5158301/429533.

@jacebrowning
Copy link
Copy Markdown
Collaborator Author

Expected: undefined, Actual: null

@davehunt Could you help me reason about these JavaScript failures?

@davehunt
Copy link
Copy Markdown
Collaborator

Took me a while, but it appears that PhantomJS doesn't support String.includes... here's a solution from StackOverflow: https://stackoverflow.com/a/31361163/154975 I'd suggest adding this to test.js.

@jacebrowning
Copy link
Copy Markdown
Collaborator Author

@davehunt Thanks! This should be ready for review.

@davehunt
Copy link
Copy Markdown
Collaborator

davehunt commented Jun 1, 2018

Thanks @jacebrowning!

@davehunt davehunt merged commit 13a299f into pytest-dev:master Jun 1, 2018
@Formartha
Copy link
Copy Markdown

Great!!

@jacebrowning jacebrowning deleted the custom-collapsed branch June 1, 2018 11:53
@ssbarnea ssbarnea added the feature This issue/PR relates to a feature request. label Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature This issue/PR relates to a feature request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature request - open html log with closed details

4 participants