Prevent collection issues with skip statements inside packages#764
Merged
seifertm merged 4 commits intopytest-dev:mainfrom Jan 28, 2024
Merged
Conversation
…age when any module inside the package used a pytest.skip statement. Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #764 +/- ##
==========================================
- Coverage 94.37% 94.33% -0.04%
==========================================
Files 2 2
Lines 480 477 -3
Branches 97 95 -2
==========================================
- Hits 453 450 -3
+ Misses 19 17 -2
- Partials 8 10 +2 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pytest-asyncio-0.23.4a2 suffers from a problem that causes tests to be skipped during the collection phase as described in
#729 (comment)
It turns out the tests were skipped, because the test suite in question used test packages and the first module inside the package issued a
pytest.skipstatement. The custom collection function for packages introduced in pytest-asyncio-0.23.4a2 tries to accessModule.objwhich triggers thepytest.skipand causes the collection of the package to abort.Rather than trying to access
Module.obj, this patch adds a package-scoped fixture to a stack each time a package is collected. The first module inside each package tries to pop an item from the stack and adds the popped loop fixture to itself.