nodes: keep plugins which subclass Item, File working for a bit more#9279
Merged
The-Compiler merged 2 commits intopytest-dev:mainfrom Nov 8, 2021
Merged
nodes: keep plugins which subclass Item, File working for a bit more#9279The-Compiler merged 2 commits intopytest-dev:mainfrom
The-Compiler merged 2 commits intopytest-dev:mainfrom
Conversation
bluetech
commented
Nov 8, 2021
| ): | ||
|
|
||
| class SoWrong(nodes.File, nodes.Item): | ||
| class SoWrong(nodes.Item, nodes.File): |
Member
Author
There was a problem hiding this comment.
This is the order which triggers the crash before this patch, and seems to be more common, so I just switched the test to use it.
For reference, in the plugin corpus I couldn't find any which directly do File, Item, but found these which do Item, File:
pytest-translations/pytest_translations/mo_files.py
11:class MoFileItem(Item, File):
pytest-checkipdb/pytest_checkipdb.py
27:class CheckIpdbItem(pytest.Item, pytest.File):
pytest-todo/todo/plugin.py
22:class TodoItem(pytest.Item, pytest.File):
pytest-isort/pytest_isort/__init__.py
167:class IsortItem(pytest.Item, pytest.File):
pytest-reqs/pytest_reqs.py
122:class ReqsItem(pytest.Item, pytest.File):
pytest-mccabe/pytest_mccabe.py
60:class McCabeItem(pytest.Item, pytest.File):
pytest-yapf/pytest_yapf.py
27:class YapfItem(pytest.Item, pytest.File):
pytest-flake8/pytest_flake8.py
95:class Flake8Item(pytest.Item, pytest.File):
pytest-black/pytest_black.py
45:class BlackItem(pytest.Item, pytest.File):
pytest-eradicate/pytest_eradicate.py
48:class EradicateItem(pytest.Item, pytest.File):
pytest-cram/pytest_cram/__init__.py
50:class CramItem(pytest.Item, pytest.File):
The-Compiler
approved these changes
Nov 8, 2021
Member
The-Compiler
left a comment
There was a problem hiding this comment.
Seems fine to me, thanks for digging into it!
nicoddemus
approved these changes
Nov 8, 2021
Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
Member
|
Took the freedom to apply @nicoddemus' spelling fix suggestion and queue this for merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #8435.