Skip to content

Replace custom flask theme by the official one#6453

Merged
The-Compiler merged 1 commit intomasterfrom
use-standard-flask-theme
Jun 1, 2020
Merged

Replace custom flask theme by the official one#6453
The-Compiler merged 1 commit intomasterfrom
use-standard-flask-theme

Conversation

@nicoddemus
Copy link
Member

Ref: #6402

@nicoddemus
Copy link
Member Author

The pages can be seen here: https://docs.pytest.org/en/use-standard-flask-theme/

@RonnyPfannschmidt
Copy link
Member

not "perfect", but my first impression is a lot better
thanks for setting it up

@nicoddemus nicoddemus marked this pull request as ready for review January 14, 2020 10:51
@nicoddemus nicoddemus changed the title Replace custom flask theme by the official one [WIP] Replace custom flask theme by the official one Jan 14, 2020
@nicoddemus nicoddemus mentioned this pull request May 30, 2020
@nicoddemus nicoddemus force-pushed the use-standard-flask-theme branch from 784f777 to bfafaec Compare May 30, 2020 14:26
@nicoddemus nicoddemus changed the title [WIP] Replace custom flask theme by the official one Replace custom flask theme by the official one May 30, 2020
@nicoddemus
Copy link
Member Author

Since we didn't get traction in other fronts, I suggest we go ahead with this style: it is an updated flask theme at least, and already an improvement IMHO. We can always apply another theme later if we decide on a better one.

What do you guys think?

@The-Compiler
Copy link
Member

Sounds good - thanks @nicoddemus! 👍

@The-Compiler The-Compiler merged commit 2f406bb into master Jun 1, 2020
@The-Compiler The-Compiler deleted the use-standard-flask-theme branch June 1, 2020 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants