WIP Node._repr_failure_py: use abspath with changed cwd#6429
Closed
blueyed wants to merge 1 commit intopytest-dev:masterfrom
Closed
WIP Node._repr_failure_py: use abspath with changed cwd#6429blueyed wants to merge 1 commit intopytest-dev:masterfrom
blueyed wants to merge 1 commit intopytest-dev:masterfrom
Conversation
|
I think relative to invocation dir is important to keep the error messages short and readable. |
Member
|
Looks like a good start, thanks 👍 |
|
I think this should be merged now. Changing to use directory relative to invocation dir can be done later. |
Contributor
Author
|
@lhupfeldt there are 2 other TODOs anyway, and I'd rather have it finished when/while doing the test for it, instead of adjusting the test later again. |
Member
|
Superseded by #7220 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6428.
TODO: