terminal: _get_main_color: help pytest-parallel#6261
terminal: _get_main_color: help pytest-parallel#6261blueyed merged 1 commit intopytest-dev:masterfrom
Conversation
Use `dict.keys()` to work around `__iter__` not working with a multiprocessing DictProxy. Ref: python/cpython#17333 Fixes pytest-dev#6254. Ref: kevlened/pytest-parallel#36
|
LGTM, but pytest-parallel should implement the full dict interface themselves I believe, because this is very brittle and might break again in the future. |
|
the location of this failure is also a indication about how "broken" pytest-parallel is last i checked, its mechanisms for laying out ipc/test execution seemed rather problematic, |
I understand and agree with the sentiment, but this is a 1-line change which doesn't really impact us, that's why I think it is harmless. But just to be clear, it is my understanding that there's absolutely no guarantee that we will maintain this compatibility, hence, this might break again in the future, so pytest-parallel should also fix this on their side. |
|
They're using a DictProxy, not implementing the dict itself, and from what I can tell might be a bug in Python then (python/cpython#17333). Anyway, I agree that pytest-parallel's monkeypatching of pytest internals is brittle in general, and hope that this can be improved in the long run. |
Use
dict.keys()to work around__iter__not working with amultiprocessing DictProxy.
Ref: python/cpython#17333
Fixes #6254.
Ref: kevlened/pytest-parallel#36