Show test module in the PytestCollectionWarning message#5346
Merged
asottile merged 1 commit intoMay 30, 2019
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5346 +/- ##
==========================================
- Coverage 93.97% 93.82% -0.16%
==========================================
Files 115 115
Lines 26278 26282 +4
Branches 2589 2589
==========================================
- Hits 24694 24658 -36
- Misses 1267 1305 +38
- Partials 317 319 +2
Continue to review full report at Codecov.
|
nicoddemus
commented
May 30, 2019
| testdir.makepyfile( | ||
| """ | ||
| class TestClass1(object): | ||
| def __new__(self): |
Member
Author
There was a problem hiding this comment.
Note: this was being tested in a separate test about namedtuple support. Decided to make a specific test for this instead.
blueyed
approved these changes
May 30, 2019
blueyed
left a comment
Contributor
There was a problem hiding this comment.
Great!
Strictly speaking it should go to features though I think.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #5330