Fix disable_test_id_escaping_and_forfeit_all_rights_to_community_support option when using a list of test IDs#5294
Merged
asottile merged 2 commits intoMay 21, 2019
Conversation
…port` option when using a list of test IDs
Codecov Report
@@ Coverage Diff @@
## master #5294 +/- ##
==========================================
+ Coverage 91.45% 91.53% +0.08%
==========================================
Files 115 115
Lines 26165 26212 +47
Branches 2578 2582 +4
==========================================
+ Hits 23928 23993 +65
+ Misses 1916 1894 -22
- Partials 321 325 +4
Continue to review full report at Codecov.
|
asottile
approved these changes
May 21, 2019
asottile
left a comment
Member
There was a problem hiding this comment.
looks good, should we add a small demo test for this "feature" (we currently don't have any showing whether it works or not) -- or naah and leave it to "community support 🤣
nicoddemus
requested changes
May 21, 2019
nicoddemus
left a comment
Member
There was a problem hiding this comment.
As @asottile mentions, please add a test so we avoid future regressions. 👍
Contributor
Author
|
Added some tests 🙂 |
nicoddemus
approved these changes
May 21, 2019
nicoddemus
left a comment
Member
There was a problem hiding this comment.
Thanks @akiomik, great contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5286 .