Skip to content

Improve mark docs#5265

Merged
nicoddemus merged 4 commits into
pytest-dev:masterfrom
nicoddemus:register-markers
May 15, 2019
Merged

Improve mark docs#5265
nicoddemus merged 4 commits into
pytest-dev:masterfrom
nicoddemus:register-markers

Conversation

@nicoddemus

@nicoddemus nicoddemus commented May 15, 2019

Copy link
Copy Markdown
Member
  • Add an introductory section about how to register marks, including doing so programatically (Need a programmatic way to register markers #5255).
  • Move section about mark revamp and iteration to historical notes: This has been in place for a long time now, since 3.6.
  • Mention "-m".

@nicoddemus nicoddemus mentioned this pull request May 15, 2019
Closed
4 tasks
@codecov

codecov Bot commented May 15, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #5265 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5265      +/-   ##
==========================================
+ Coverage   91.22%   91.35%   +0.12%     
==========================================
  Files         115      115              
  Lines       26163    26159       -4     
  Branches     2578     2578              
==========================================
+ Hits        23868    23898      +30     
+ Misses       1967     1939      -28     
+ Partials      328      322       -6
Impacted Files Coverage Δ
testing/python/integration.py 63.57% <0%> (-27.86%) ⬇️
testing/python/collect.py 79.31% <0%> (-8.53%) ⬇️
testing/test_warnings.py 97.26% <0%> (-1.64%) ⬇️
testing/test_tmpdir.py 97.31% <0%> (-1.62%) ⬇️
src/_pytest/nodes.py 94.11% <0%> (-1.48%) ⬇️
src/_pytest/fixtures.py 96.55% <0%> (-1.38%) ⬇️
testing/python/metafunc.py 93.93% <0%> (-0.74%) ⬇️
src/_pytest/python.py 92.25% <0%> (-0.49%) ⬇️
src/_pytest/capture.py 95.09% <0%> (-0.03%) ⬇️
testing/test_capture.py 99.24% <0%> (-0.01%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8f7e50...e44a2ef. Read the comment docs.

blueyed
blueyed approved these changes May 15, 2019
View reviewed changes
Comment thread doc/en/example/markers.rst Outdated
Comment thread doc/en/historical-notes.rst Outdated
Comment thread doc/en/historical-notes.rst Outdated
Comment thread doc/en/historical-notes.rst
nicoddemus and others added 4 commits May 15, 2019 20:45
@nicoddemus
Revamp the mark section in the docs
7e8044f 
Add an introductory section about how to register marks,
including doing so programatically (pytest-dev#5255).
@nicoddemus
Move section about mark revamp and iteration to historical notes
a31098a 
This has been in place for a long time now, since 3.6.
@nicoddemus
Mention "-m" in the main mark docs
c6e3ff3
@nicoddemus @blueyed
Apply suggestions from code review
e44a2ef 
Co-Authored-By: Daniel Hahler <github@thequod.de>
@nicoddemus

nicoddemus commented May 15, 2019

Copy link
Copy Markdown
Member Author

Docs passed on Travis, merging. 👍

@nicoddemus nicoddemus merged commit 9642427 into pytest-dev:master May 15, 2019
@nicoddemus nicoddemus deleted the register-markers branch May 15, 2019 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@blueyed blueyed blueyed approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nicoddemus @blueyed