Skip to content

Restore usedevelop=True now that pip 19.1.1 restored the old behavior#5222

Merged
nicoddemus merged 1 commit into
pytest-dev:masterfrom
nicoddemus:restore-usedevelop
May 7, 2019
Merged

Restore usedevelop=True now that pip 19.1.1 restored the old behavior#5222
nicoddemus merged 1 commit into
pytest-dev:masterfrom
nicoddemus:restore-usedevelop

Conversation

@nicoddemus

@nicoddemus nicoddemus commented May 6, 2019

Copy link
Copy Markdown
Member

Fix #5167

asottile
asottile approved these changes May 7, 2019
View reviewed changes

@asottile asottile left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicoddemus nicoddemus merged commit d76735f into pytest-dev:master May 7, 2019
@nicoddemus nicoddemus deleted the restore-usedevelop branch May 7, 2019 13:01
@blueyed

blueyed commented May 14, 2019

Copy link
Copy Markdown
Contributor

Azure does not have/use pip 19.1.1 apparently? (for some envs only)
https://pytest-dev.visualstudio.com/pytest/_build/results?buildId=1073&view=logs&jobId=e38d3164-b5f2-578d-f4d9-260ae069b587&taskId=8198004e-82e3-5b60-c14f-a5b1a78c79f7&lineStart=74&lineEnd=75&colStart=1&colEnd=1

@asottile

asottile commented May 14, 2019

Copy link
Copy Markdown
Member

this is part of the changes in latest tox which defaults to the bundled version of pip w/ virtualenv instead of unconfigurably reaching to pypi for the latest version

we can opt into the unpinned behaviour by setting download=true on the testenv -- or I can bug @gaborbernat to make a virtualenv release with pip 19.1.1 😆

@asottile

asottile commented May 14, 2019

Copy link
Copy Markdown
Member

actually, looks like that's already in motion! pypa/virtualenv@be82612

@gaborbernat

gaborbernat commented May 14, 2019

Copy link
Copy Markdown
Contributor

Doing the new release is a WIP... Will probably do it in the morning.

@nicoddemus nicoddemus mentioned this pull request May 14, 2019
Closed
@gaborbernat

gaborbernat commented May 15, 2019

Copy link
Copy Markdown
Contributor

Done via pypa/virtualenv#1357

@blueyed

blueyed commented May 15, 2019

Copy link
Copy Markdown
Contributor

Thanks!

@hackebrot hackebrot mentioned this pull request May 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asottile asottile asottile approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pip 19.1 prevents pytest from being used in editable mode

4 participants

@nicoddemus @blueyed @asottile @gaborbernat