Skip to content

Revert "Merge pull request #4854 from blueyed/pdb-skip"#5173

Merged
asottile merged 1 commit into
pytest-dev:featuresfrom
blueyed:revert
Apr 27, 2019
Merged

Revert "Merge pull request #4854 from blueyed/pdb-skip"#5173
asottile merged 1 commit into
pytest-dev:featuresfrom
blueyed:revert

Conversation

@blueyed

@blueyed blueyed commented Apr 27, 2019

Copy link
Copy Markdown
Contributor

This reverts commit e88aa95, reversing
changes made to 1410d3d.

I do not think it warrants an option anymore, and there is a way to
achieve this via --pdbcls if needed.

@blueyed
Revert "Merge pull request pytest-dev#4854 from blueyed/pdb-skip"
308b733 
This reverts commit e88aa95, reversing
changes made to 1410d3d.

I do not think it warrants an option anymore, and there is a way to
achieve this via `--pdbcls` if needed.
@blueyed blueyed mentioned this pull request Apr 27, 2019
Merged
2 tasks
asottile
asottile approved these changes Apr 27, 2019
View reviewed changes

@asottile asottile left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov

codecov Bot commented Apr 27, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #5173 into features will increase coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           features    #5173      +/-   ##
============================================
+ Coverage     95.84%   96.11%   +0.26%     
============================================
  Files           115      115              
  Lines         25989    25979      -10     
  Branches       2563     2561       -2     
============================================
+ Hits          24910    24970      +60     
+ Misses          758      706      -52     
+ Partials        321      303      -18
Impacted Files Coverage Δ
testing/test_pdb.py 99.19% <ø> (+0.38%) ⬆️
src/_pytest/debugging.py 89.18% <ø> (-0.23%) ⬇️
src/_pytest/fixtures.py 97.93% <0%> (+0.27%) ⬆️
testing/test_assertrewrite.py 84.04% <0%> (+0.29%) ⬆️
testing/test_capture.py 99.24% <0%> (+0.3%) ⬆️
testing/test_config.py 99.49% <0%> (+0.33%) ⬆️
src/_pytest/pytester.py 91.63% <0%> (+0.42%) ⬆️
src/_pytest/assertion/rewrite.py 95.47% <0%> (+0.48%) ⬆️
testing/python/fixtures.py 99.08% <0%> (+0.57%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76c6ed8...308b733. Read the comment docs.

@asottile asottile merged commit ac7ee40 into pytest-dev:features Apr 27, 2019
@blueyed blueyed deleted the revert branch April 27, 2019 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asottile asottile asottile approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@blueyed @asottile