Skip test_source_mtime_long_long on 32bit and lower platforms by mimi1vx · Pull Request #5045 · pytest-dev/pytest

mimi1vx · 2019-04-04T10:55:16Z

Create a new changelog file in the changelog folder, with a name like <ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.
Target the master branch for bug fixes, documentation updates and trivial changes.
Target the features branch for new features and removals/deprecations.
Include documentation when adding new features.
Include new tests or update existing tests when applicable.

Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:

[x ] Add yourself to AUTHORS in alphabetical order;

codecov · 2019-04-04T11:08:14Z

Codecov Report

Merging #5045 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #5045      +/-   ##
=========================================
- Coverage   96.06%     96%   -0.07%     
=========================================
  Files         114     114              
  Lines       25768   25769       +1     
  Branches     2548    2548              
=========================================
- Hits        24754   24739      -15     
- Misses        704     715      +11     
- Partials      310     315       +5

Impacted Files	Coverage Δ
testing/test_assertrewrite.py	`84.06% <100%> (+0.02%)`	⬆️
src/_pytest/assertion/util.py	`93.38% <0%> (-4.29%)`	⬇️
src/_pytest/unittest.py	`93.12% <0%> (-1.06%)`	⬇️
src/_pytest/doctest.py	`95.69% <0%> (-0.72%)`	⬇️
testing/test_pdb.py	`98.99% <0%> (-0.21%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 973301b...77526f4. Read the comment docs.

blueyed · 2019-04-04T12:01:30Z

Thanks!

The test was added for #4903 - /cc @bmwiedemann

Just for future reference: you should use "Fixes …" in commit message, especially given that you have created an issue already.

bmwiedemann · 2019-04-04T12:13:12Z

hmm. Wasnt there this size & 0xffffffff that is supposed to handle overly large files? If something is broken there, there should be a better fix than this.

waiting for feedback

mimi1vx · 2019-04-05T10:36:12Z

@bmwiedemann python Integer bigger that 2^31-1 can't be converted to 'int' on a platform where sys.maxsize is 2^31-1 .. so this test is wrong on this platforms, and proprely cast OverflowError Exception

bmwiedemann · 2019-04-05T10:53:02Z

The test is not doing a cast to int. And the code specifically uses "L" for unsigned to have a 0..2^32-1 range. Maybe including a backtrace would make the problem clearer.

nicoddemus · 2019-04-09T22:25:22Z

The traceback was included in #5046 (comment):

[  348s]         timestamp = 2 ** 32 + offset
[  348s] >       os.utime(str(p), (timestamp, timestamp))
[  348s] E       OverflowError: Python int too large to convert to C long

And seems to be failing for both -1 and +1 offsets.

Strangely, this passes for me on 32-bit Python 2.7 on Windows:

λ python -c "import platform;print platform.architecture()"
('32bit', 'WindowsPE')

λ pytest testing\ -k test_source_mtime_long_long -v
======================== test session starts ========================
platform win32 -- Python 2.7.13, pytest-4.4.1.dev51+g1ed4ae863, py-1.6.0, pluggy-0.9.0
...

testing/test_assertrewrite.py::test_source_mtime_long_long[-1] PASSED [ 50%]
testing/test_assertrewrite.py::test_source_mtime_long_long[1] PASSED [100%]

============= 2 passed, 2383 deselected in 3.30 seconds =============

On 64-bits Python I get, as expected:

λ py -3.6 -c "import platform;print(platform.architecture())"
('64bit', 'WindowsPE')

I would expect to be able to reproduce this...

nicoddemus · 2019-05-01T14:27:09Z

@mimi1vx any updates on this? Can you please post the output of:

λ python -c "import platform;print platform.architecture()"
('32bit', 'WindowsPE')

In your system?

mimi1vx · 2019-05-07T11:59:26Z

@nicoddemus

[    3s] + python2 -c 'import platform;print platform.architecture()'
[    3s] ('32bit', 'ELF')

nicoddemus · 2019-05-07T12:04:26Z

@mimi1vx interesting, thanks. Which OS is that?

mimi1vx · 2019-05-07T12:06:57Z

@nicoddemus ELF - > linux

btw>

abuild@penguin:~> python2 
Python 2.7.16 (default, Mar 04 2019, 07:13:50) [GCC] on linux2
>>> timestamp = 2 ** 32 +1
>>> import os
>>> os.utime(str("/etc/os-release"), (timestamp, timestamp))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
OverflowError: Python int too large to convert to C long

abuild@penguin:~> python3
Python 3.7.2 (default, Dec 30 2018, 16:18:15) [GCC] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import os
>>> timestamp = 2 ** 32 +1
>>> os.utime(str("/etc/os-release"), (timestamp, timestamp))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
OverflowError: timestamp out of range for platform time_t
>>>

nicoddemus · 2019-05-07T12:21:58Z

I see, thanks!

Well now that's been clarified, I think it is harmless to merge this, otherwise the test blows up anyway. 👍

mimi1vx mentioned this pull request Apr 4, 2019

test_source_mtime_long_long fails on 32bit platforms #5046

Closed

4 tasks

Skip test_source_mtime_long_long on 32bit and lower platforms

77526f4

blueyed previously approved these changes Apr 4, 2019

View reviewed changes

nicoddemus added the status: needs information reporter needs to provide more information; can be closed after 2 or more weeks of inactivity label May 4, 2019

nicoddemus changed the title ~~Skip test_source_mtime_long_long on 32bit and lower platforms~~ WIP Skip test_source_mtime_long_long on 32bit and lower platforms May 4, 2019

nicoddemus approved these changes May 7, 2019

View reviewed changes

nicoddemus changed the title ~~WIP Skip test_source_mtime_long_long on 32bit and lower platforms~~ Skip test_source_mtime_long_long on 32bit and lower platforms May 7, 2019

bmwiedemann approved these changes May 7, 2019

View reviewed changes

nicoddemus merged commit ef4dec0 into pytest-dev:master May 7, 2019

mimi1vx deleted the 32bit branch May 7, 2019 14:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Skip test_source_mtime_long_long on 32bit and lower platforms#5045

Skip test_source_mtime_long_long on 32bit and lower platforms#5045
nicoddemus merged 1 commit into
pytest-dev:masterfrom
mimi1vx:32bit

mimi1vx commented Apr 4, 2019

Uh oh!

codecov Bot commented Apr 4, 2019 •

edited

Loading

Uh oh!

blueyed commented Apr 4, 2019

Uh oh!

bmwiedemann commented Apr 4, 2019

Uh oh!

mimi1vx commented Apr 5, 2019

Uh oh!

bmwiedemann commented Apr 5, 2019

Uh oh!

nicoddemus commented Apr 9, 2019

Uh oh!

nicoddemus commented May 1, 2019

Uh oh!

mimi1vx commented May 7, 2019

Uh oh!

nicoddemus commented May 7, 2019

Uh oh!

mimi1vx commented May 7, 2019

Uh oh!

nicoddemus commented May 7, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

mimi1vx commented Apr 4, 2019

Uh oh!

codecov Bot commented Apr 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueyed commented Apr 4, 2019

Uh oh!

bmwiedemann commented Apr 4, 2019

Uh oh!

mimi1vx commented Apr 5, 2019

Uh oh!

bmwiedemann commented Apr 5, 2019

Uh oh!

nicoddemus commented Apr 9, 2019

Uh oh!

nicoddemus commented May 1, 2019

Uh oh!

mimi1vx commented May 7, 2019

Uh oh!

nicoddemus commented May 7, 2019

Uh oh!

mimi1vx commented May 7, 2019

Uh oh!

nicoddemus commented May 7, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented Apr 4, 2019 •

edited

Loading