Fix pytest tests invocation with custom PYTHONPATH#4914
Merged
Conversation
This was referenced Mar 12, 2019
asottile
approved these changes
Mar 12, 2019
asottile
left a comment
Member
There was a problem hiding this comment.
otherwise looks good! Thanks for the patch 🎉
Codecov Report
@@ Coverage Diff @@
## master #4914 +/- ##
=========================================
+ Coverage 95.68% 95.7% +0.01%
=========================================
Files 113 113
Lines 25169 25170 +1
Branches 2498 2498
=========================================
+ Hits 24083 24088 +5
+ Misses 767 764 -3
+ Partials 319 318 -1
Continue to review full report at Codecov.
|
nicoddemus
reviewed
Mar 12, 2019
Fixes pytest-dev#4913 Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
Member
Author
|
I'm running a check to see if the current patch actually fixes the issue. It might take a few minutes. |
Member
Author
|
It does. |
blueyed
approved these changes
Mar 12, 2019
blueyed
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch, and sorry for breaking it.
Member
Author
|
@blueyed don't worry about it, it's pretty nonstandard setup, it breaks all the time :D |
Member
|
Thanks everyone! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4913
changelogfolder...masterbranch for bug fixes, documentation updates and trivial changes.AUTHORSin alphabetical order (already there)