Skip to content

Travis: add cron_only stage for py38-dev#4789

Merged
blueyed merged 1 commit into
pytest-dev:masterfrom
blueyed:travis-pluggymaster-cron
Feb 13, 2019
Merged

Travis: add cron_only stage for py38-dev#4789
blueyed merged 1 commit into
pytest-dev:masterfrom
blueyed:travis-pluggymaster-cron

Conversation

@blueyed

@blueyed blueyed commented Feb 13, 2019

Copy link
Copy Markdown
Contributor

The master and features branches are tested daily, so we can test
pluggymaster only therein.

@blueyed

blueyed commented Feb 13, 2019

Copy link
Copy Markdown
Contributor Author

Canceled CI manually. Travis job matrix looks OK, but should be reviewed/checked with the cron job after merging.

@blueyed blueyed requested a review from nicoddemus February 13, 2019 17:52
@blueyed

blueyed commented Feb 13, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Should we also move py38-dev there?

@nicoddemus

nicoddemus commented Feb 13, 2019

Copy link
Copy Markdown
Member

I'm 👎 , if a PR breaks because it is incompatible with pluggy-master (which might not be the latest) I want to detect that as early as possible.

@blueyed
Travis: test py38-dev only with cron builds
afaaa7e 
The master and features branches are tested daily.
@blueyed blueyed force-pushed the travis-pluggymaster-cron branch from cba5546 to afaaa7e Compare February 13, 2019 18:02
@blueyed

blueyed commented Feb 13, 2019

Copy link
Copy Markdown
Contributor Author

Hmm, ok.

What about moving py38-dev there then only for now? (amended like that)

And what about dropping py{27,37}-xdist, or py27/py37 then, but test them with the pluggymaster jobs (either like currently without xdist, or use xdist there also)?

@blueyed blueyed changed the title Travis: test pluggymaster only with cron builds Travis: add cron_only stage for py38-dev Feb 13, 2019
@blueyed

blueyed commented Feb 13, 2019

Copy link
Copy Markdown
Contributor Author

@nicoddemus
What about this PR as-is?

nicoddemus
nicoddemus approved these changes Feb 13, 2019
View reviewed changes

@nicoddemus nicoddemus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@blueyed blueyed merged commit c84ae0b into pytest-dev:master Feb 13, 2019
@blueyed blueyed deleted the travis-pluggymaster-cron branch February 13, 2019 21:03
@blueyed

blueyed commented Feb 15, 2019

Copy link
Copy Markdown
Contributor Author

JFI: cron_only gets skipped/canceled if an earlier stage failed already: https://travis-ci.org/pytest-dev/pytest/builds/493572571
Can we improve this?

@nicoddemus

nicoddemus commented Feb 15, 2019

Copy link
Copy Markdown
Member

Don't know from the top of my head 🤔

blueyed added a commit to blueyed/pytest that referenced this pull request Feb 15, 2019
@blueyed
Travis: remove cron_only stage, use conditional job
e4c0827 
Ref: pytest-dev#4789 (comment)
blueyed added a commit to blueyed/pytest that referenced this pull request Feb 15, 2019
@blueyed
Travis: remove cron_only stage, use conditional job
bcde329 
Ref: pytest-dev#4789 (comment)
blueyed added a commit to blueyed/pytest that referenced this pull request Feb 15, 2019
@blueyed
Travis: remove cron_only stage, use conditional job
4f9e835 
Ref: pytest-dev#4789 (comment)
@blueyed blueyed mentioned this pull request Feb 15, 2019
Merged
@blueyed

blueyed commented Feb 15, 2019

Copy link
Copy Markdown
Contributor Author

Via conditional jobs: #4803

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@blueyed @nicoddemus