Skip to content

WIP: collection fixes/improvements#4748

Closed
blueyed wants to merge 2 commits into
pytest-dev:featuresfrom
blueyed:remove-node_cache
Closed

WIP: collection fixes/improvements#4748
blueyed wants to merge 2 commits into
pytest-dev:featuresfrom
blueyed:remove-node_cache

Conversation

@blueyed

@blueyed blueyed commented Feb 8, 2019

Copy link
Copy Markdown
Contributor

Not feeling really comfortable about this regarding test coverage in this regard in the past.
Using this to refactor/clean up things.

@blueyed blueyed changed the base branch from master to features February 8, 2019 19:08
@pytest-dev pytest-dev deleted a comment from codecov Bot Feb 8, 2019
@nicoddemus

Copy link
Copy Markdown
Member

Hi @blueyed,

It has been a long time since it has last seen activity, plus we have made sweeping changes on master to drop Python 2.7 and 3.4 support, so this PR has some conflicts which require attention.

In order to clear up our queue and let us focus on the active PRs, I'm closing this PR for now.

Please don't consider this a rejection of your PR, we just want to get this out of sight until you have the time to tackle this again. If you get around to work on this in the future, please don't hesitate in re-opening this!

Thanks for your work, the team definitely appreciates it!

@nicoddemus nicoddemus closed this Jun 6, 2019
@pytest-dev pytest-dev deleted a comment from codecov Bot Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants