Skip to content

pytest.main: collect: factor out _visit_filter#4747

Merged
blueyed merged 1 commit into
pytest-dev:masterfrom
blueyed:visit-filter
Feb 8, 2019
Merged

pytest.main: collect: factor out _visit_filter#4747
blueyed merged 1 commit into
pytest-dev:masterfrom
blueyed:visit-filter

Conversation

@blueyed

@blueyed blueyed commented Feb 8, 2019

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread src/_pytest/main.py
if six.PY2:

@staticmethod
def _visit_filter(f):

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i recall this can be stored as constant using methodcaller('check', file=True, notext="pyc")

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I understand correctly, but there is no "notext" in py.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a ext checker method and the not prefix of the kwarg triggers inversion ^^
its horrendous in a funny way

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would rather keep it like it is now (i.e. only move it), but feel free to push an update, or patch here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RonnyPfannschmidt
What do you plan? Either post a patch/push a fixup (feel free to squash), or approve it, please.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yikes, thanks for the call out, i missed that bit

@blueyed blueyed merged commit b4b2f58 into pytest-dev:master Feb 8, 2019
@blueyed blueyed deleted the visit-filter branch February 8, 2019 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants