Skip to content

Mention that pytest_plugins should not be used as module name#4735

Merged
RonnyPfannschmidt merged 1 commit into
pytest-dev:masterfrom
kohr-h:pytest_plugins_module_name
Feb 7, 2019
Merged

Mention that pytest_plugins should not be used as module name#4735
RonnyPfannschmidt merged 1 commit into
pytest-dev:masterfrom
kohr-h:pytest_plugins_module_name

Conversation

@kohr-h

@kohr-h kohr-h commented Feb 6, 2019

Copy link
Copy Markdown
Contributor
  • Create a new changelog file in the changelog folder, with a name like <ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.
  • Target the master branch for bug fixes, documentation updates and trivial changes.

As discussed in #3899

@kohr-h kohr-h force-pushed the pytest_plugins_module_name branch from 24dc4ba to 7445b53 Compare February 6, 2019 20:57

@nicoddemus nicoddemus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @kohr-h!

@codecov

codecov Bot commented Feb 7, 2019

Copy link
Copy Markdown

Codecov Report

Merging #4735 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4735      +/-   ##
==========================================
+ Coverage   95.67%   95.72%   +0.05%     
==========================================
  Files         113      113              
  Lines       24969    25185     +216     
  Branches     2478     2548      +70     
==========================================
+ Hits        23889    24109     +220     
  Misses        762      762              
+ Partials      318      314       -4
Flag Coverage Δ
#docs 29.61% <ø> (+0.1%) ⬆️
#doctesting 29.61% <ø> (+0.1%) ⬆️
#linting 29.61% <ø> (+0.1%) ⬆️
#linux 95.5% <ø> (ø) ⬆️
#nobyte 92.36% <ø> (+0.71%) ⬆️
#numpy 93.15% <ø> (+51.06%) ⬆️
#pexpect 42.08% <ø> (ø) ⬆️
#py27 93.75% <ø> (+0.09%) ⬆️
#py34 91.85% <ø> (+0.26%) ⬆️
#py35 91.84% <ø> (+0.26%) ⬆️
#py36 91.86% <ø> (+0.3%) ⬆️
#py37 93.87% <ø> (+0.07%) ⬆️
#trial 93.15% <ø> (+51.06%) ⬆️
#windows 93.86% <ø> (+0.61%) ⬆️
#xdist 93.78% <ø> (+0.06%) ⬆️
Impacted Files Coverage Δ
testing/test_terminal.py 99.85% <0%> (+0.04%) ⬆️
src/_pytest/terminal.py 92.84% <0%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 429485e...7445b53. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented Feb 7, 2019

Copy link
Copy Markdown

Codecov Report

Merging #4735 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4735      +/-   ##
==========================================
+ Coverage   95.67%   95.72%   +0.05%     
==========================================
  Files         113      113              
  Lines       24969    25185     +216     
  Branches     2478     2548      +70     
==========================================
+ Hits        23889    24109     +220     
  Misses        762      762              
+ Partials      318      314       -4
Flag Coverage Δ
#docs 29.61% <ø> (+0.1%) ⬆️
#doctesting 29.61% <ø> (+0.1%) ⬆️
#linting 29.61% <ø> (+0.1%) ⬆️
#linux 95.5% <ø> (ø) ⬆️
#nobyte 92.36% <ø> (+0.71%) ⬆️
#numpy 93.15% <ø> (+51.06%) ⬆️
#pexpect 42.08% <ø> (ø) ⬆️
#py27 93.75% <ø> (+0.09%) ⬆️
#py34 91.85% <ø> (+0.26%) ⬆️
#py35 91.84% <ø> (+0.26%) ⬆️
#py36 91.86% <ø> (+0.3%) ⬆️
#py37 93.87% <ø> (+0.07%) ⬆️
#trial 93.15% <ø> (+51.06%) ⬆️
#windows 93.86% <ø> (+0.61%) ⬆️
#xdist 93.78% <ø> (+0.06%) ⬆️
Impacted Files Coverage Δ
testing/test_terminal.py 99.85% <0%> (+0.04%) ⬆️
src/_pytest/terminal.py 92.84% <0%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 429485e...7445b53. Read the comment docs.

@RonnyPfannschmidt RonnyPfannschmidt merged commit 526f4a9 into pytest-dev:master Feb 7, 2019
@RonnyPfannschmidt

Copy link
Copy Markdown
Member

👍

@kohr-h kohr-h deleted the pytest_plugins_module_name branch February 7, 2019 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants