Call pytest_report_collectionfinish hook when --collect-only is passed#4725
Merged
Conversation
asottile
approved these changes
Feb 6, 2019
asottile
left a comment
Member
There was a problem hiding this comment.
Just for my curiosity, what's the difference between option.collectonly and getoption("collect-only")?
Codecov Report
@@ Coverage Diff @@
## master #4725 +/- ##
==========================================
- Coverage 95.68% 95.66% -0.02%
==========================================
Files 113 113
Lines 24963 24963
Branches 2478 2479 +1
==========================================
- Hits 23886 23882 -4
Misses 762 762
- Partials 315 319 +4
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #4725 +/- ##
==========================================
- Coverage 95.68% 95.66% -0.02%
==========================================
Files 113 113
Lines 24963 24963
Branches 2478 2479 +1
==========================================
- Hits 23886 23882 -4
Misses 762 762
- Partials 315 319 +4
Continue to review full report at Codecov.
|
426d6e0 to
c72cb4f
Compare
Member
Author
None, except the former is not really recommended anymore, not sure what's the specific reason for it. |
c72cb4f to
54af0f4
Compare
Zac-HD
approved these changes
Feb 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2895