Skip to content

Count tests#4673

Merged
nicoddemus merged 5 commits into
pytest-dev:featuresfrom
kown7:count-tests
Jan 24, 2019
Merged

Count tests#4673
nicoddemus merged 5 commits into
pytest-dev:featuresfrom
kown7:count-tests

Conversation

@kown7

@kown7 kown7 commented Jan 24, 2019

Copy link
Copy Markdown
Contributor

Thanks for submitting a PR, your contribution is really appreciated!

See #4660

asottile
asottile approved these changes Jan 24, 2019
View reviewed changes

@asottile asottile left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile

asottile commented Jan 24, 2019

Copy link
Copy Markdown
Member

If you'd like, add yourself to AUTHORS as well 🎉 https://github.com/pytest-dev/pytest/blob/master/AUTHORS

@nicoddemus

nicoddemus commented Jan 24, 2019

Copy link
Copy Markdown
Member

Also please add a changelog entry 👍

@codecov

codecov Bot commented Jan 24, 2019

Copy link
Copy Markdown

Codecov Report

Merging #4673 into features will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           features    #4673      +/-   ##
============================================
+ Coverage     95.67%   95.71%   +0.04%     
============================================
  Files           111      111              
  Lines         24750    24753       +3     
  Branches       2460     2461       +1     
============================================
+ Hits          23679    23692      +13     
+ Misses          754      751       -3     
+ Partials        317      310       -7
Flag Coverage Δ
#docs 29.7% <33.33%> (+0.1%) ⬆️
#doctesting 29.7% <33.33%> (+0.1%) ⬆️
#linting 29.7% <33.33%> (+0.1%) ⬆️
#linux 95.52% <100%> (+0.02%) ⬆️
#nobyte 92.32% <100%> (+0.01%) ⬆️
#numpy 93.15% <100%> (+0.04%) ⬆️
#pexpect 42.12% <100%> (+0.03%) ⬆️
#py27 93.72% <100%> (+0.03%) ⬆️
#py34 91.81% <100%> (+0.06%) ⬆️
#py35 91.83% <100%> (+0.06%) ⬆️
#py36 91.85% <100%> (+0.06%) ⬆️
#py37 93.87% <100%> (+0.02%) ⬆️
#trial 93.15% <100%> (+0.04%) ⬆️
#windows 93.9% <100%> (+0.02%) ⬆️
#xdist 93.73% <100%> (ø) ⬆️
Impacted Files Coverage Δ
testing/test_terminal.py 99.81% <ø> (ø) ⬆️
testing/test_cacheprovider.py 99.72% <ø> (ø) ⬆️
src/_pytest/terminal.py 91.87% <100%> (+0.89%) ⬆️
src/_pytest/capture.py 94.11% <0%> (+0.45%) ⬆️
src/_pytest/cacheprovider.py 97.16% <0%> (+1.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daf3911...6d38868. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented Jan 24, 2019

Copy link
Copy Markdown

Codecov Report

Merging #4673 into features will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           features    #4673      +/-   ##
============================================
+ Coverage     95.67%   95.71%   +0.04%     
============================================
  Files           111      111              
  Lines         24750    24753       +3     
  Branches       2460     2461       +1     
============================================
+ Hits          23679    23692      +13     
+ Misses          754      751       -3     
+ Partials        317      310       -7
Flag Coverage Δ
#docs 29.7% <33.33%> (+0.1%) ⬆️
#doctesting 29.7% <33.33%> (+0.1%) ⬆️
#linting 29.7% <33.33%> (+0.1%) ⬆️
#linux 95.52% <100%> (+0.02%) ⬆️
#nobyte 92.32% <100%> (+0.01%) ⬆️
#numpy 93.15% <100%> (+0.04%) ⬆️
#pexpect 42.12% <100%> (+0.03%) ⬆️
#py27 93.72% <100%> (+0.03%) ⬆️
#py34 91.81% <100%> (+0.06%) ⬆️
#py35 91.83% <100%> (+0.06%) ⬆️
#py36 91.85% <100%> (+0.06%) ⬆️
#py37 93.87% <100%> (+0.02%) ⬆️
#trial 93.15% <100%> (+0.04%) ⬆️
#windows 93.9% <100%> (+0.02%) ⬆️
#xdist 93.73% <100%> (ø) ⬆️
Impacted Files Coverage Δ
testing/test_terminal.py 99.81% <ø> (ø) ⬆️
testing/test_cacheprovider.py 99.72% <ø> (ø) ⬆️
src/_pytest/terminal.py 91.87% <100%> (+0.89%) ⬆️
src/_pytest/capture.py 94.11% <0%> (+0.45%) ⬆️
src/_pytest/cacheprovider.py 97.16% <0%> (+1.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daf3911...6d38868. Read the comment docs.

@nicoddemus

nicoddemus commented Jan 24, 2019

Copy link
Copy Markdown
Member

Went ahead and added the CHANGELOG myself. 😁

@kown7

kown7 commented Jan 24, 2019

Copy link
Copy Markdown
Contributor Author

Went ahead and added the CHANGELOG myself. 😁

Thanks - haven't had time until now.

@nicoddemus nicoddemus merged commit 51dd738 into pytest-dev:features Jan 24, 2019
@nicoddemus

nicoddemus commented Jan 24, 2019

Copy link
Copy Markdown
Member

Awesome, thanks again @kown7!

@kown7

kown7 commented Jan 25, 2019

Copy link
Copy Markdown
Contributor Author

Wasn't more than a few lines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asottile asottile asottile approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kown7 @asottile @nicoddemus @scs-kno