remove and ban py.io.BytesIO, py.process, py.path.local.sysfind#4661
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4661 +/- ##
==========================================
+ Coverage 95.69% 95.71% +0.02%
==========================================
Files 113 113
Lines 24885 24889 +4
Branches 2458 2458
==========================================
+ Hits 23813 23822 +9
+ Misses 756 754 -2
+ Partials 316 313 -3
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #4661 +/- ##
==========================================
+ Coverage 95.69% 95.71% +0.02%
==========================================
Files 113 113
Lines 24885 24889 +4
Branches 2458 2458
==========================================
+ Hits 23813 23822 +9
+ Misses 756 754 -2
+ Partials 316 313 -3
Continue to review full report at Codecov.
|
RonnyPfannschmidt
approved these changes
Jan 22, 2019
Member
|
👍 |
twmr
reviewed
Jan 22, 2019
|
|
||
| def test_bytes_io(): | ||
| f = py.io.BytesIO() | ||
| f = io.BytesIO() |
Contributor
There was a problem hiding this comment.
This test only tests code from the stdlib and can be removed IMO.
Member
Author
There was a problem hiding this comment.
lol true, want to make a patch for it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.